Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 6ce0c8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a callback that returns
ResultAsync<unknown, string> | ResultAsync<unknown, number>toErr.asyncAndThrough, or to aResultunion, currently fails type checking.Ok.asyncAndThroughalready supports this inference, but the Err overload does not.Mirror the existing inferred overload on Err. Add exact type assertions through both Err and Result public types. Runtime short-circuit behavior is unchanged.
Validation: the two calls fail with TS2345 before the fix. Afterward,
npm testpasses 117 runtime tests and all type tests, including the new assertions;npm run typecheck,npm run lint, andnpm run buildpass.AI assistance: this change and its regression tests were developed with OpenAI Codex. The listed checks were run locally.