Repository navigation
Restore --delete to the docs sync - #5293
Conversation
Left out of #5287 because the first sync would have removed 12 pages that docs.json nav and 15 redirects still pointed at. Those have landed: superfly/docs#2530 retired the litefs-cloud pages and #2535 the duplicate root page. Verified before restoring: generating from master and comparing against superfly/docs main gives identical page sets, 305 each, and zero changed pages. So --delete removes nothing today, and from now on a command removed from flyctl stops being documented.
Neither script uses set -e and out/ is cleared before generating, so a failed generator leaves out/ empty and the rsync, now with --delete, would remove every page. The review requirement would catch the resulting PR, but the script should not rely on that. A floor rather than set -e: set -e would abort the label-preservation loop, where [ -n "$label" ] && awk ... returns non-zero for the 270 pages that carry no sidebarTitle.
|
Added a floor check before the rsync. Neither this script nor Used a floor rather than Worth noting the interaction: |
Closes the second half of superfly/docs-tracking#350.
#5287 left
--deleteout of the rsync because the first sync would also have removed 12 pages that docs.json nav entries and 15 redirects still pointed at. Both halves have now landed: superfly/docs#2530 retired the litefs-cloud command pages, superfly/docs#2535 the duplicate root page.Verified before restoring: generating from current master and comparing against
superfly/docsmain gives identical page sets, 305 each, and zero changed pages. So this deletes nothing today.What it prevents: the litefs-cloud commands were removed in #5187 on 8 September and their eleven pages stayed live for four weeks, documenting a CLI that was not in the binary. Without
--deletethat happens every time a command goes.One consequence, noted in the comment: nothing hand-written can live in
flyctl/cmdnow, since the sync will remove it.