Repository navigation
Add s1 feedback command via the Agentback SDK - #12
Merged
Merged
Conversation
Mounts agentback/cli's runFeedbackCommand as `s1 feedback`. Reports carry the logged-in account signed by GET /feedback/identity when the lookup succeeds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7jAP9YsE7D4HvphbaKNCc
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7jAP9YsE7D4HvphbaKNCc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: CLI users and the agents driving the CLI had no way to report problems with Search1API.
After:
s1 feedback "what went wrong"sends a report to the Search1API team. It supports--category,--intent,--request-id,--modeland--json, and-reads the message from stdin. When the user is logged in, the report is linked to their account. The welcome screen and README list the command.How:
runFeedbackCommandfrom the publicagentbackSDK (0.2.0) is mounted as a commander subcommand that passes its arguments through, using the project's write-only public key. Before sending, it calls the gateway's newGET /feedback/identitythroughfetchWithAuth, so API keys and OAuth (including refresh) both work, and attaches the signed account. If that lookup fails, the report is sent without an account.Depends on fatwang2/search1api
claude/agentback-sdkforGET /feedback/identity. Until that is deployed, reports still send, just without an account.npm testpasses on Node 22 and Node 18 (30 tests). The SDK declares Node >=20, which on Node 18 only produces an npm engine warning; the code paths the CLI uses run on 18.Generated by Claude Code