fix: minor improvements to splinter CI and the lint manifest build - #187
Merged
Conversation
The push trigger targeted `master`, but the default branch is `main`, so tests only ran on pull requests and never after a merge. The matrix version was exported as PG_VERSION, while docker-compose reads SUPABASE_VERSION and the Dockerfile declares ARG SUPABASE_VERSION, so every run built against the hardcoded 15.1.1.13 image no matter what the matrix said. Use SUPABASE_VERSION throughout, refresh the pinned image, and add 17 to the matrix.
The categories regex used a lazy `.*?` under DOTALL, so in a lint with an earlier `array[...]` the capture ran across it to the trailing `as categories` and returned the whole span as garbage categories. This hit 0023/0024/0025, whose SECURITY category came out as junk and then dropped them from category-filtered Advisor runs. Match a single `array[...]` with `[^\]]*` so the capture can't leave its own array.
utkarash2991
changed the title
utkarash2991
requested review from
imor and
soedirgo
and removed request for
imor
September 8, 2026 16:41
17 exposes a pre-existing version-pinned assertion in the 0022 test (amcheck default is 1.4 on 17, the expected output pins 1.3). Track adding 17 with that test fix separately.
The 0022 test pinned amcheck's available version (1.3), which differs on 17 (1.4) and was the only failure when 17 was in the matrix. Drop the version- dependent columns from the assertion and add 17 back.
soedirgo
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small build/CI fixes.
CI: the
pushtrigger wasmaster, but the default branch ismain, so tests only ran on PRs. And the matrix version was exported asPG_VERSIONwhile compose/Dockerfile readSUPABASE_VERSION, so every run built the hardcoded15.1.1.13image regardless of the matrix. Align onSUPABASE_VERSION, refresh the pin, and test 15 and 17.Manifest:
compile_json.py's categories regex was lazy underDOTALL, so in lints with an earlierarray[...]it captured across it and returned garbage. 0023/0024/0025 lost theirSECURITYcategory and dropped out of category-filtered Advisor runs. Match a singlearray[...]with[^\]]*.0022 test: it pinned amcheck's available version (1.3), which is 1.4 on 17 and was the only thing failing there. The assertion now drops the version-dependent columns, so it holds on both.
Tracking: PSQL-1654