Repository navigation
Conversation
Add postgres-env-15-debug and postgres-env-17-debug with the debug output only. Drop the source and debug paths from postgres-env-15 and postgres-env-17. Add realise-postgres-debug to fetch the matching debug env from the binary cache. Keep source and debug in postgres-env-orioledb-17 for its testinfra tests and coredump diagnostics. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PostgreSQL Extension Dependency Analysis: PR #2537
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2537
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
…out-of-postgres-env
3 of 4 tasks
Strip pgrx .so files fully and build them with separateDebugInfo. Add the per-version debug outputs of wrappers, pg_graphql, and pg_jsonschema to the debug env. realise-postgres-debug installs the debug env into the postgres-debug profile. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Add postgres-env-orioledb-17-debug with the debug output, orioledb.debug, and the source tree. Every env now carries realise-postgres-debug and cleanup-postgres-debug. The testinfra tests and the coredump processor read the postgres-debug profile, and the tests realise it first. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
realise-postgres-debug now only realises the debug env and prints its store path. Drop the postgres-debug profile and cleanup-postgres-debug. The tests and the coredump processor use the printed path, and garbage collection removes the debug env. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 73 -> 73 (2 paths added, 2 paths removed, delta +0, disk usage +0B).x86_64-linux: Closure size: 74 -> 74 (2 paths added, 2 paths removed, delta +0, disk usage +0B). |
This comment has been minimized.
This comment has been minimized.
The extensions get their own debug env. Drop the per-version debug outputs of wrappers, pg_graphql, and pg_jsonschema from the postgres debug env. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…out-of-postgres-env
brainrake
marked this pull request as ready for review
October 10, 2026 00:24
Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
symlinkJoin is never substituted, so CI did not build or push the debug envs and realise-postgres-debug could not fetch them. Allow substitutes so CI builds and caches them. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rence debugEnvPath builds the debug env and stores its path in a file without references. realise-postgres-debug reads it. Add the orioledb debug env to the checks so CI builds and caches it. Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pashkinelfe
previously requested changes
Oct 12, 2026
Contributor
There was a problem hiding this comment.
Orioledb beta state progression relies heavily on printing stack traces in cases of crashes. Turning on this was agreed previously. Removing symbols may break existing core dump printing workflow. To merge this PR first we'll need to investigate if they are not broken or easily fixable FYI: @pgnickb
brainrake
marked this pull request as draft
October 13, 2026 08:50
Collaborator
Author
|
Decision: keep postgres orioledb debug data in ami but with |
Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
brainrake
marked this pull request as ready for review
October 13, 2026 11:19
This comment has been minimized.
This comment has been minimized.
…processor Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pgnickb
approved these changes
Oct 14, 2026
…out-of-postgres-env
Refs: MPG-1336 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…out-of-postgres-env
…out-of-postgres-env
…-split-debug-symbols-out-of-postgres-env # Conflicts: # nix/packages/postgres-env.nix
This comment has been minimized.
This comment has been minimized.
…out-of-postgres-env
…out-of-postgres-env
brainrake
marked this pull request as draft
October 27, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
postgres-env-*ship the debug symbols, and the 15 and 17 envs also ship the PostgreSQL source tree. These are large and very rarely needed.Summary
postgres-env-15-debug,postgres-env-17-debug, andpostgres-env-orioledb-17-debugwith the debug output. The orioledb one also hasorioledb.debugand the source tree.postgres-env-orioledb-17, so the symbols,orioledb.debug, and the source stay in the same closure as the binaries and update with them. The coredump processor reads symbols from the profile, as on develop..sofiles with a full strip, and build them withseparateDebugInfo. The symbols go to a separate debug output. The 15 and 17 debug envs ship thewrappers,pg_graphql, andpg_jsonschemaones.realise-postgres-debugto the env. It realises the debug env from the binary cache and prints its store path. The path is stored without a reference, so it stays out of the closure, and garbage collection removes the debug env.symlinkJoinis never substituted, so CI did not build or cache them and the instance could not fetch them.Result
Closure on aarch64-linux, from
nix path-info -S.postgres-env-15postgres-env-17postgres-env-orioledb-17Debug envs, fetched on demand by
realise-postgres-debug. Unpacked is what the runtime env does not already have.postgres-env-15-debugpostgres-env-17-debugpostgres-env-orioledb-17-debugpostgres-env-orioledb-17Test plan
postgres-env-{15,17,orioledb-17}andpostgres-env-{15,17}-debugevaluaterealise-postgres-debugrealises the debug env on an instanceMPG-1336