Skip to content

ci: gate nix Linux packages on glibc 2.31 floor #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brainrake wants to merge 3 commits into
base: develop
Choose a base branch
from
+26 −0
Draft

ci: gate nix Linux packages on glibc 2.31 floor #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
705284d
ci: fail nix package builds that exceed glibc 2.31 floor
brainrake Sep 8, 2026
e77bbbd
ci: report offending file path in glibc floor check
brainrake Sep 8, 2026
d4127ea
style: shfmt check-glibc-floor.sh
brainrake Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/nix-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ jobs:
uses: ./.github/actions/nix-build-retry
with:
attr: .#${{ matrix.attr }}
- name: Check glibc floor
if: ${{ matrix.attr != '' }}
run: ./scripts/check-glibc-floor.sh "${{ matrix.attr }}"

nix-build-checks-aarch64-linux:
name: >-
Expand Down Expand Up @@ -192,6 +195,9 @@ jobs:
uses: ./.github/actions/nix-build-retry
with:
attr: .#${{ matrix.attr }}
- name: Check glibc floor
if: ${{ matrix.attr != '' }}
run: ./scripts/check-glibc-floor.sh "${{ matrix.attr }}"

nix-build-checks-x86_64-linux:
name: >-
Expand Down
20 changes: 20 additions & 0 deletions scripts/check-glibc-floor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/usr/bin/env bash
# Fails if any file in ./result requires a glibc symbol version above MAX_ALLOWED.
set -Eeu -o pipefail

MAX_ALLOWED="2.31"

HIT=$(find -L result -type f -exec sh -c \
'objdump -T "$1" 2>/dev/null | grep -oE "GLIBC_[0-9.]+" | sed -E "s#GLIBC_([0-9.]+)#\1 $1#"' _ {} \; |
sort -V | tail -1)

if [ -z "$HIT" ]; then
exit 0
fi

FLOOR=${HIT%% *}
echo "glibc floor: $FLOOR (max allowed: $MAX_ALLOWED)"
if [ "$(printf '%s\n%s' "$MAX_ALLOWED" "$FLOOR" | sort -V | tail -1)" != "$MAX_ALLOWED" ]; then
echo "::error::glibc floor $HIT exceeds max allowed $MAX_ALLOWED in ${1:-result}"
exit 1
fi
Loading