supautils: match prod debug symbols and glibc symbol versions - #2436
Draft
brainrake wants to merge 4 commits into
Draft
supautils: match prod debug symbols and glibc symbol versions#2436brainrake wants to merge 4 commits into
brainrake wants to merge 4 commits into
Conversation
PostgreSQL Package Dependency Analysis: PR #2436
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
The fallback silently re-resolved strtol to its default (newest) version if the GLIBC_2.17 lookup ever failed, defeating the whole point of the patch. GLIBC_2.17 is strtol's only version node in modern glibc (the 2.38 one is a distinct symbol, __isoc23_strtol, from the C23 variant of atoi/stdlib.h), and it's already comfortably below the project's glibc 2.31 floor, so no version bump is needed here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
GLIBC_2.17 isn't a valid version node for dlvsym/strtol on x86_64 (verified via objdump against the real glibc: x86_64's nodes are 2.2.5/2.34, since that symbol's ABI never changed at 2.17 there). It only worked on aarch64 because aarch64 support was added in glibc 2.17, making that its earliest possible tag. Pin per-arch: 2.2.5 on x86_64, 2.17 on aarch64. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
PostgreSQL Extension Dependency Analysis: PR #2436
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forces atoi to resolve plain strtol directly, since modern glibc's atoi macro pulls in the C23 __isoc23_strtol@GLIBC_2.38 variant instead — unavailable on deployed hosts. Pins per-arch to strtol's oldest real version node: GLIBC_2.2.5 on x86_64, GLIBC_2.17 on aarch64 (verified against the actual glibc via objdump — 2.17 isn't a valid node on x86_64 at all).
Also dropped the unversioned dlsym fallback: it silently fell back to the newest strtol on lookup failure, defeating the fix.
Related MPG-17