feat(nix): add nix-dl, retry+timeout wrapper for nix-store -r - #2434
Closed
brainrake wants to merge 1 commit into
Closed
feat(nix): add nix-dl, retry+timeout wrapper for nix-store -r#2434brainrake wants to merge 1 commit into
brainrake wants to merge 1 commit into
Conversation
brainrake
marked this pull request as draft
September 8, 2026 01:05
brainrake
added a commit
that referenced
this pull request
Sep 8, 2026
Swaps the inline nix-store -r --option stalled-download-timeout call for the shared nix-dl wrapper from #2434 (timeout+retry, since stalled-download-timeout doesn't reliably fire: NixOS/nix#2560).
brainrake
marked this pull request as ready for review
September 8, 2026 01:39
brainrake
marked this pull request as draft
September 8, 2026 01:46
brainrake
added a commit
that referenced
this pull request
Sep 8, 2026
Swaps the inline nix-store -r --option stalled-download-timeout call for the shared nix-dl wrapper from #2434 (timeout+retry, since stalled-download-timeout doesn't reliably fire: NixOS/nix#2560).
nix-store -r can stall indefinitely on a dropped connection without erroring out (NixOS/nix#2560); guard each path with a timeout and retry, matching the pattern already used in ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh. site-extensions-update now uses it instead of a bare nix-store -r call.
brainrake
force-pushed
the
claude/download-nix-store-paths-util
branch
from
September 8, 2026 09:34
0342c5f to
959d46e
Compare
PostgreSQL Extension Dependency Analysis: PR #2434
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2434
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Collaborator
Author
|
Dropping this: the two issues cited (NixOS/nix#8758, NixOS/nix#15419) describe long bounded stalls with eventual retry, not an indefinite hang — the premise doesn't hold up. Reverted its two call sites (site-extensions-update, site-env-update in #2424) back to a direct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stalled-download-timeoutexists but is global and its default is often too long).nix-dl, a shared package wrapping each path realize intimeout+retry, matching the pattern already inansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh.NIX_DL_TIMEOUT/NIX_DL_KILL_GRACE/NIX_DL_ATTEMPTS(defaults 120s/10s/3).site-extensions-updatenow uses it instead of a barenix-store -rcall.Test plan
nix build .#nix-dl— builds, shellcheck passesnix build .#site-extensions-update— builds