fix(pgmq): resolve drop_queue overloading bug - #2433
Open
brainrake wants to merge 5 commits into
Open
Conversation
brainrake
marked this pull request as draft
September 8, 2026 00:23
brainrake
added a commit
that referenced
this pull request
Sep 8, 2026
PostgreSQL Extension Dependency Analysis: PR #2433
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2433
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
This comment has been minimized.
This comment has been minimized.
Two drop_queue overloads collapse into one merged drop_queue(text, boolean), same as verified in the NixOS test.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unchanged Multigres-OrioleDB expected output still contains both overloads and will fail its interface regression test.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes pgmq setup failures caused by overloaded drop_queue signatures.
Changes:
- Replaces historical overloads with one defaulted two-argument function.
- Adds regression coverage for oldest/newest pinned pgmq versions.
- Updates extension-interface snapshots.
File summaries
| File | Description |
|---|---|
ansible/.../pgmq/after-create.sql |
Merges drop_queue overloads. |
nix/ext/tests/pgmq-drop-queue-overload.nix |
Adds regression testing. |
nix/tests/expected/pgmq.out |
Updates pgmq function snapshot. |
nix/tests/expected/z_15_ext_interface.out |
Updates PG15 interface snapshot. |
nix/tests/expected/z_17_ext_interface.out |
Updates PG17 interface snapshot. |
nix/tests/expected/z_orioledb-17_ext_interface.out |
Updates OrioleDB snapshot. |
nix/tests/expected/z_multigres-17_ext_interface.out |
Updates Multigres snapshot. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2400 unpaused
Fixes: pgmq.drop_queue can have 2 overloads (text) and (text, boolean). Detach/drop both known signatures directly, then recreate a single merged drop_queue(text, boolean default false).
Includes its own regression test (nix/ext/tests/pgmq-drop-queue-overload.nix), verified against pgmq's oldest/newest pinned versions. #2431 (pgmq version bump to 1.13.0) is rebased on top of this - merge here first.
FDBKIN-8821