Repository navigation
fix(ext/ai): use SHA-256 for ONNX session cache keys - #754
Merged
Merged
Conversation
kallebysantos
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ONNX session cache (
SESSIONS) keyed entries by XXH3-64 (model bytes) and FxHash (model URL), and trusted a key match without re-checking the model.Neither hash is collision-resistant. Both keys and the on-disk
.checksumnow use SHA-256; bytes are hashed onspawn_blockingso the heavier hash stays off the isolate thread.Cache directory names change, so models are re-downloaded once on the next cold start after upgrading.