Repository navigation
fix(base/worker): guard cleanup-triggered early drop against in-flight requests - #753
Merged
Merged
Conversation
kallebysantos
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TryCleanupIdleWorkers decided a worker had no pending work purely from
req_ack_count == req_demand, which is trivially true both right after
boot (both still 0) and in the brief gap between one request's ack and
the next one's delivery. A cleanup sweep landing in that window could
retire the isolate before an already-routed request ever reached it,
surfacing as a 504 to the caller.
Require the worker to have stayed caught-up for a short grace period
(cleanup_idle_grace, default 100ms, overridable via
context.supervisor.cleanupIdleGraceMs) before allowing a
cleanup-triggered drop.