Repository navigation
chore(repo): fix the API package sync and a CodeQL alert - #7416
Conversation
The Management API spec now sets `contentEncoding` on the ESZIP upload body. Effect's OpenAPI 3.0 converter refuses `contentEncoding` and `contentMediaType`, so `pnpm generate` and the hourly API package sync fail. Both are annotations and `format: binary` already carries the encoding, so the sanitizer drops them.
Resolves the CodeQL `js/incomplete-sanitization` alert in `publish.ts`.
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. After reading every diff hunk and the surrounding PR code, I agree: package-name encoding remains compatible, and content annotation removal preserves user-defined property names and binary format annotations. Tests were not run because dependencies are unavailable.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Two things have been turning develop's checks red.
contentEncoding: "binary"on the ESZIP upload body, and Effect's OpenAPI 3.0 converter rejectscontentEncodingandcontentMediaTypebecause they'd become active keywords in Draft 2020-12. Both are only annotations andformat: binaryalready says the same thing, sosanitizeOpenApiSchemanow drops them. Once this lands, the next sync run should open the backlog PR for@supabase/api.js/incomplete-sanitizationinapps/cli/scripts/publish.ts, becausename.replace("/", "%2F")only replaces the first slash. It shows up on every develop commit through the production deploy PR. It'sreplaceAllnow - no package name has more than one slash, so there's no behaviour change.v2.xhas the samepublish.tsline. With no behaviour change I don't think it needs a backport, unless we want the alert cleared there too.🤖 Generated with Claude Code