Repository navigation
test(cli-e2e): cover the e2e tests with effect lint (CLI-2879) - #7385
Conversation
There was a problem hiding this comment.
🤖 AI Review
Verified Claude’s single finding as a consistency nit; Codex reported no findings. No functional defect was established. Lint and tests were not run because dependencies are absent.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli-e2e/src/tests/telemetry.e2e.test.ts:99 |
consistency |
claude | The migrated telemetry test retains a JSON.parse assertion inside Effect.gen, while the newly added workspace guidance says Effect lint rejects JSON.parse in Effect code. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
|
passed the flake check here: https://github.com/supabase/cli/actions/runs/40980043982 |
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
TL;DR
brings the
apps/cli-e2etest files and their fixtures under the effect lintwhats introduced?
runandrunNoProjectIdreturn effects, every test body runs through onerunE2eedge, and control calls go through onepostControlhelper instead offetchref