Repository navigation
test(cli-e2e): cover the e2e harness with effect lint (CLI-2878) - #7384
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Confirmed Claude’s cleanup finding as a minor correctness concern, with corrected line references. The resource leak predates this PR; no additional regressions were identified by static inspection.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli-e2e/tests/setup.ts:197 |
error-handling |
claude | Setup failures leave the manually created scope unclosed. In record mode, failures before cleanup registration leave the servers running and can orphan the staging project. This resource leak also existed before the PR. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
TL;DR
brings the
apps/cli-e2eharness under the effect lintwhats introduced?
env.tsreads the environment throughConfigand passes the record mode and staging url to the global setup instead of rewritingprocess.envref