Repository navigation
Add support for templating the set of supported python versions #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| # Main CI Workflow {%- set default_python = '3.13' %} | ||
| # Main CI Workflow | ||
| {%- set pys = cookiecutter.supported_python_versions.split(',') | map('trim') | list %} | ||
| {%- set default_python = pys[-2] %} | ||
| {%- set cp_tags = pys | map('replace', '.', '') | join(',') %} | ||
| name: CI | ||
|
|
||
| on: | ||
|
|
@@ -40,7 +43,7 @@ jobs: | |
| coverage: codecov-oidc | ||
| toxdeps: tox-pypi-filter | ||
| envs: | | ||
| - linux: py313 | ||
| - linux: py{{ default_python | replace('.', '') }} | ||
|
|
||
| sdist_verify: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -67,11 +70,13 @@ jobs: | |
| toxdeps: tox-pypi-filter | ||
| posargs: -n auto | ||
| envs: | | ||
| - linux: py314 | ||
| - windows: py312 | ||
| - macos: py312 | ||
| - linux: py312-oldestdeps | ||
| - linux: py314-devdeps | ||
| {%- for v in pys[1:] %} | ||
| - linux: py{{ v | replace('.', '') }} | ||
| {%- endfor %} | ||
| - windows: py{{ pys | first | replace('.', '') }} | ||
| - macos: py{{ pys[1] | replace('.', '') }} | ||
| - linux: py{{ pys | first | replace('.', '') }}-oldestdeps | ||
| - linux: py{{ pys | last | replace('.', '') }}-devdeps | ||
|
Comment on lines
+73
to
+79
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It turns out it was reasonably hard to encode my gut instinct about what the [platform, version] matrix should be in jinja code. As currently written we test the two oldest pythons on windows & macos and the newer ones on linux. Given the SPEC 0 rotation we should generally have 3 or maybe 4 supported Pythons. I think the latest one should be linux as it's more likely to work [compile quickly] when a version is very new.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this actually makes it clearer what combinations run, I think it could be doc'd quickly the specific combinations we run. |
||
|
|
||
| docs: | ||
| needs: [core] | ||
|
|
@@ -99,7 +104,7 @@ jobs: | |
| toxdeps: tox-pypi-filter | ||
| coverage: codecov-oidc | ||
| envs: | | ||
| {% endfor -%} | ||
| {% endfor -%} | ||
| {%- endif %} | ||
|
|
||
| build_dists: | ||
|
|
@@ -117,10 +122,10 @@ jobs: | |
| with: | ||
| sdist: true | ||
| targets: | | ||
| - cp3{12,13,14}-manylinux*_x86_64 | ||
| - cp3{12,13,14}-macosx_x86_64 | ||
| - cp3{12,13,14}-macosx_arm64 | ||
| - cp3{12,13,14}-win_amd64 | ||
| - cp{{ '{' ~ cp_tags ~ '}' }}-manylinux*_x86_64 | ||
| - cp{{ '{' ~ cp_tags ~ '}' }}-macosx_x86_64 | ||
| - cp{{ '{' ~ cp_tags ~ '}' }}-macosx_arm64 | ||
| - cp{{ '{' ~ cp_tags ~ '}' }}-win_amd64 | ||
| {%- else %} | ||
| uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@1285b95e32c783cfa40eb2ffbd6ca4cd023fb884 # v3.2.2 | ||
| with: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this job is ran again below in test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, don't think I care.