fix(extensions): expose top-level metadata in YAML extension files#170
Merged
tokoko merged 1 commit intoJun 11, 2026
Merged
Conversation
build_simple_extensions populated metadata for functions and types but silently dropped the file-level metadata field, so it was not available at runtime. Pass it through and add tests covering metadata exposure at the file, function, and type levels. Fixes substrait-io#149 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
tokoko
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_simple_extensions populated metadata for functions and types but
silently dropped the file-level metadata field, so it was not available
at runtime. This completes the metadata exposure work started in #168.
and type levels, plus the default-None case.
Implementation-level (Impl/Impl1/Impl2) and TypeVariation schema classes
have no metadata field, so there is nothing to expose there.
Testing
Fixes #149
🤖 Generated with Claude Code