feat(core)!: remove deprecated Aggregate.Grouping.grouping_expressions field#857
Open
nielspardon wants to merge 1 commit into
Open
feat(core)!: remove deprecated Aggregate.Grouping.grouping_expressions field#857nielspardon wants to merge 1 commit into
nielspardon wants to merge 1 commit into
Conversation
… field BREAKING CHANGE: removes the deprecated Aggregate.Grouping.grouping_expressions field which was removed in Substrait v0.88.0 Signed-off-by: Niels Pardon <par@zurich.ibm.com>
bestbeforetoday
changed the title
vbarua
approved these changes
Jun 11, 2026
vbarua
left a comment
vbarua
left a comment
Member
There was a problem hiding this comment.
Removing this before the submodule bump makes sense to me.
This library has been dual writing the groupings outputs for a while now, so users should be able to migrate their consumers to handle the new grouping expression format if they haven't already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes the deprecated Aggregate.Grouping.grouping_expressions field which was removed in Substrait v0.88.0
Closes #805
I'm not sure how to best introduce these changes. We could update the Git submodule first which then breaks a whole lot of code which we would all need to migrate in one big PR or we gradually introduce the changes in PRs like this one and then update the git submodule.