Bound logs collector memory to avoid ClickHouse INSERT spiral#67
Merged
Conversation
A failed oversized INSERT left the watermark unadvanced, so each round re-requested the same logs plus new ones, growing the next INSERT until it could never succeed. - Cap buffered logs by estimated memory; drop excess (re-collected later) - Dump in memory-bounded chunks so no single INSERT can be too large Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kalabukdima
force-pushed
the
fix-memory-usage
branch
from
f80e806 to
9195818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed oversized INSERT left the last timestamp unadvanced, so each round re-requested the same logs plus new ones, growing the next INSERT indefinitely.
Note that after this change some logs may end up never being collected if they were dropped and there was another log with the same timestamp.