Use Classical Gram–Schmidt twice instead of Modified G-S with conditional re-orthogonalization.#2791
Merged
pcarruscag merged 8 commits intodevelopfrom Apr 22, 2026
Merged
Use Classical Gram–Schmidt twice instead of Modified G-S with conditional re-orthogonalization.#2791pcarruscag merged 8 commits intodevelopfrom
pcarruscag merged 8 commits intodevelopfrom
Conversation
Contributor
|
Nice! So it's faster per iteration, not faster because it converges in less iterations I guess? How much faster re we talking about? |
Member
Author
|
Yes per iteration. Maybe 1.4x for the orthogonalization part, which is only significant for many linear iterations since it scales quadratically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Doing CGS twice is faster (if not implemented naively) and at least as robust.
PR Checklist
pre-commit run --allto format old commits.