CI: Permit cleared PHPStan baselines during level upgrades - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The level-7 rollout exposed a gap in our baseline guard: Media Categories has cleared its old PHPStan baseline, but the guard also freezes the configuration that needs to move from level 5 to 7. This permits that retirement only when the baseline is deleted, the level rises, and the configuration otherwise stays the same except for the named WordPress compatibility stub. The existing quality job still runs the unchanged Composer analyzer command afterward.
I also refreshed the centrally approved Composer and PHPUnit bootstrap hashes against the exact, GitHub-verified heads of the eleven open level-7 plugin PRs. No compatibility floors, release settings, workflow permissions, or plugin code change here.
I have left this draft for the central CI run and an independent policy review.