Skip to content

[fix] Fix issues caused by the RabbitMQ client upgrade #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Technoboy- merged 1 commit into from
Aug 22, 2026
Merged

[fix] Fix issues caused by the RabbitMQ client upgrade #1893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .../test/java/io/streamnative/pulsar/handlers/amqp/rabbitmq/functional/UnexpectedFrames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public UnexpectedFrames() {
public void missingHeader() throws IOException {
expectUnexpectedFrameError(new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_HEADER) {
if (frame.getType() == AMQP.FRAME_HEADER) {
return null;
}
return frame;
Expand All @@ -119,11 +119,11 @@ public Frame confuse(Frame frame) {
public void missingMethod() throws IOException {
expectUnexpectedFrameError(new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_METHOD) {
if (frame.getType() == AMQP.FRAME_METHOD) {
// We can't just skip the method as that will lead us to
// send 0 bytes and hang waiting for a response.
return new Frame(AMQP.FRAME_HEADER,
frame.channel, frame.getPayload());
frame.getChannel(), frame.getPayload());
}
return frame;
}
Expand All @@ -134,7 +134,7 @@ public Frame confuse(Frame frame) {
public void missingBody() throws IOException {
expectUnexpectedFrameError(new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_BODY) {
if (frame.getType() == AMQP.FRAME_BODY) {
return null;
}
return frame;
Expand All @@ -146,10 +146,10 @@ public Frame confuse(Frame frame) {
public void wrongClassInHeader() throws IOException {
expectUnexpectedFrameError(new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_HEADER) {
if (frame.getType() == AMQP.FRAME_HEADER) {
byte[] payload = frame.getPayload();
Frame confusedFrame = new Frame(AMQP.FRAME_HEADER,
frame.channel, payload);
frame.getChannel(), payload);
// First two bytes = class ID, must match class ID from
// method.
payload[0] = 12;
Expand All @@ -165,8 +165,8 @@ public Frame confuse(Frame frame) {
public void heartbeatOnChannel() throws IOException {
expectUnexpectedFrameError(new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_METHOD) {
return new Frame(AMQP.FRAME_HEARTBEAT, frame.channel);
if (frame.getType() == AMQP.FRAME_METHOD) {
return new Frame(AMQP.FRAME_HEARTBEAT, frame.getChannel());
}
return frame;
}
Expand All @@ -177,8 +177,8 @@ public Frame confuse(Frame frame) {
public void unknownFrameType() throws IOException {
expectError(AMQP.FRAME_ERROR, new Confuser() {
public Frame confuse(Frame frame) {
if (frame.type == AMQP.FRAME_METHOD) {
return new Frame(0, frame.channel,
if (frame.getType() == AMQP.FRAME_METHOD) {
return new Frame(0, frame.getChannel(),
"1234567890\0001234567890".getBytes());
}
return frame;
Expand Down
Loading