Repository navigation
fix: rebuild the BAL for Firehose staged sync - #69
Merged
Merged
Conversation
The execution stage rejects Amsterdam blocks without a block access list, and the Firehose block executor never handed one to it.
maoueh
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged sync rejected every Amsterdam block with
BlockAccessListHashMissing: the execution stage validates the block access list it gets fromtake_bal(), andFirehoseBlockExecutoralways returnedNone. The executor now rebuilds the list on both its traced and untraced paths and hands it to the stage.run_wrapped_blockleaves the rebuilt list in the state, and the newtake_traced_block_access_listchecks its hash and records its RLP on the Firehose block.staged_sync_balruns theamsterdam_block_access_listfixture through the executor the way the stage does; it fails without the fix.