fix(injected): clamp injected regions that run to the end of the file - #899
Open
stefanvanburen wants to merge 1 commit into
Open
fix(injected): clamp injected regions that run to the end of the file#899stefanvanburen wants to merge 1 commit into
stefanvanburen wants to merge 1 commit into
Conversation
Treesitter reports a region that extends to EOF as ending at (line count, col 0), which is one row past the last line. That end row is used directly as a buffer index, so merge_ranges_with_prefix hits nvim_buf_get_lines' strict indexing and the whole format call fails with "Index out of bounds", leaving the buffer unformatted. Fenced languages hide this: a closing ``` ends the region before EOF. Delimiter-less blocks do not, so a YAML block scalar as the last thing in the file reproduces it every time, as does an unclosed markdown fence. Clamp the end of such a region to the end of the final line. Fixes stevearc#452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treesitter reports a region that extends to EOF as ending at (line count, col 0), which is one row past the last line. That end row is used directly as a buffer index, so
merge_ranges_with_prefixhitsnvim_buf_get_lines' strict indexing and the whole format call fails with "Index out of bounds", leaving the buffer unformatted.Fenced languages hide this: a closing ``` ends the region before EOF. Delimiter-less blocks do not, so a YAML block scalar as the last thing in the file reproduces it every time, as does an unclosed markdown fence.
Clamp the end of such a region to the end of the final line.
Fixes #452.