Skip to content

4B. Pin what a container set after boot really does - #71

Merged
nikolaystrikhar merged 1 commit into
53-registrar-agrees-with-allfrom
59-container-set-after-boot
Aug 25, 2026
Merged

4B. Pin what a container set after boot really does#71
nikolaystrikhar merged 1 commit into
53-registrar-agrees-with-allfrom
59-container-set-after-boot

Conversation

@nikolaystrikhar

Copy link
Copy Markdown
Contributor

What: tests for Absorber::boot(), the collaborator accessors and the plugins_loaded steps when Config::set_container() is called after boot.

Usage: none — the behaviour is unchanged. What changes is that the warning on boot() is now a behaviour the suite holds: the hooks keep the container boot closed over, the accessors answer for the replacement, and a second boot() binds nothing into it.

Why this way:

A warning only a docblock makes is a warning nothing enforces. Two live containers is the failure mode a host hits by wiring set_container() from a service provider, and until now the suite would have stayed green through any change to which half resolves from where.

Asserted by loading a sub-plugin and reading Absorber::all(), not by counting resolutions. The damage is not that two containers exist — it is that the load pass works while the registry a host can reach reports nothing, with no report in between, which is exactly what a host would go debugging.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: c93da22f-eec7-4b07-98ae-7d1e3ee18882

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@nikolaystrikhar nikolaystrikhar changed the title 10B. Pin what a container set after boot really does 10B. Pin what a container set after boot really does (just tests) Aug 24, 2026
@nikolaystrikhar
nikolaystrikhar force-pushed the 59-container-set-after-boot branch from 285f889 to 849b544 Compare August 24, 2026 13:41
@nikolaystrikhar
nikolaystrikhar force-pushed the 59-container-set-after-boot branch from 849b544 to bafeed8 Compare August 25, 2026 08:45
@nikolaystrikhar nikolaystrikhar changed the title 10B. Pin what a container set after boot really does (just tests) 4B. Pin what a container set after boot really does Aug 25, 2026
@nikolaystrikhar
nikolaystrikhar force-pushed the 59-container-set-after-boot branch from bafeed8 to 45e7927 Compare August 25, 2026 09:35
@nikolaystrikhar
nikolaystrikhar merged commit 45e7927 into main Aug 25, 2026
6 of 11 checks passed
@nikolaystrikhar
nikolaystrikhar deleted the 59-container-set-after-boot branch August 25, 2026 09:41
@nikolaystrikhar

Copy link
Copy Markdown
Contributor Author

Folded into #70: 53-registrar-agrees-with-all now carries this commit, so the diff here is empty and there is no stack left to order. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant