Skip to content

6. Prove the recorder that pins the guard check ahead of the dependency check (test only) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikolaystrikhar merged 1 commit into from
Aug 25, 2026
Merged

6. Prove the recorder that pins the guard check ahead of the dependency check (test only) #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/unit/LoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,16 @@ public function test_an_already_loaded_sub_plugin_is_not_dependency_checked(): v

$this->assertSame( 0, $checked );
$this->assertSame( [], $this->queued_notices(), 'No notice for a plugin that is already running.' );

// The recorder has to be shown to work, and shown through the path the load pass skipped: a
// mistyped config key, a fixture that dropped the override, a Sub_Plugin that stopped reading
// `dependency_check` at all — each leaves this counter at zero for a reason that has nothing
// to do with the gate order, and this is the only test pinning the order that carries the
// whole re-declaration guarantee. Calling a local closure would prove none of them, since it
// is the registered object's copy that the gate order is about.
$this->assertFalse( Absorber::all()['give-recurring']->are_dependencies_met() );

$this->assertSame( 1, $checked, 'The recorder must catch a call that really happened.' );
}

public function test_the_should_load_filter_can_veto_the_load(): void {
Expand Down
Loading