Skip to content

test: fix description - #16625

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-11-14
Nov 14, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-11-14

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-11-13 13:13 -0500 (c4d7f3c4f) and 2026-11-14 03:51 -0500 (7dc18312d).

array/uint64

  • 21f4296: add the missing "or" before the last list item in the test description at lib/node_modules/@stdlib/array/uint64/test/test.fill.js (line 86), so it reads "...nonnegative bigint, or 64-bit unsigned integer".

Related Issues

Does this pull request have any related issues?

No.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • array/uint64 (the wording matches the sibling test description in test/test.set.js)

What carried over from the reference(s)?

  • The wording of the test description.

What differed, or what did you have to work out yourself?

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Reviewed 30 first-parent commits on develop (c4d7f3c4f..7dc18312d). The generated REPL data files from 554950248 were excluded.
  • What was checked:
    • Two independent style-guide audits against docs/style-guides and reference packages (array/complex128, sibling stats/base/dists/*, blas/ext/base/ndarray/*).
    • Two independent bug scans: a diff-only pass and a logic/edge-case pass.
    • Recomputed the documented example outputs for the new Uint64Array methods (copyWithin, every, fill, filter, find, findIndex, findLast) and for the ahavercos, cceil and to-reversed-dimension docs. All were correct.
    • Reviewed the ndarray/tensor0d/ctor options-mutation fix and the constants/float*/nan C refactors. No issues found.
  • Deliberately excluded:
    • Anything requiring interpretation or a judgment call.
    • Wording preferences.
    • The copyWithIn casing typo in the subject of commit 7d6191b9d, because commit history is not fixable.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated review of recently merged commits. It will be audited by a maintainer before being marked ready for review.



Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7A34WqPUR4TJD95Zys
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/uint64 $\\color{red}1648/1655$
$\\color{green}+99.58\\%$
$\\color{red}262/267$
$\\color{green}+98.13\\%$
$\\color{green}28/28$
$\\color{green}+100.00\\%$
$\\color{red}1648/1655$
$\\color{green}+99.58\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review November 14, 2026 13:58
@kgryte
kgryte requested a review from a team November 14, 2026 13:59
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 14, 2026
@kgryte kgryte changed the title docs: fix test description in array/uint64 test: fix description Nov 14, 2026
@kgryte
kgryte merged commit 9880230 into develop Nov 14, 2026
34 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-11-14 branch November 14, 2026 13:59
@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Needs Review A pull request which needs code review. labels Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants