Fix intermittent mkdir race when generating with multiple workers#222
Open
mynetx wants to merge 1 commit into
Open
Fix intermittent mkdir race when generating with multiple workers#222mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating with multiple workers, a page would intermittently fail with:
Two workers can race on the same output directory: one checks that it doesn't exist, another creates it in the meantime (e.g. while writing a child page like
/fr/stories/...), and the first worker'smkdirthen throws. Since pages are shuffled across workers, it's timing-dependent — on a small 13-page multisite it failed 5 out of 20 runs with--workers=4.This forces the directory creation, so an already-existing directory is treated as success. Genuine failures (permissions etc.) still surface through the
put()right after. With the fix, the same 20-run loop passes cleanly.Co-Authored-By: Claude noreply@anthropic.com