Conversation
Member
|
This needs a rebase and conflict resolution now because of #15456 |
Member
|
PS. In every browser I tried to load a direct mp4 file, the iframe seemed to include video controls (on 6.x). Was there a specific situation where this was helping? Regardless, this looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A direct video URL like
https://example.com/clip.mp4is rendered inside an<iframe>— the same element used for YouTube and Vimeo — so it gets no playback controls and relies on whatever the browser decides to do with a bare video document.The component already distinguishes these via its
isVideocomputed, so this renders them in a real<video controls>element instead. Lazy-loading behaviour is unchanged; thesrcis still gated onisVisible.Split out of #11871 so it can land on its own.