[6.x] Fix timezone handling in whereDate and whereTime#14940
Open
marcorieser wants to merge 1 commit into
Open
[6.x] Fix timezone handling in whereDate and whereTime#14940marcorieser wants to merge 1 commit into
whereDate and whereTime#14940marcorieser wants to merge 1 commit into
Conversation
Carbon values in a non-app timezone were reparsed using the app's default timezone, silently shifting the represented instant instead of converting it.
marcorieser
changed the title
whereDate and whereTimewhereDate and whereTime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #14939
Summary
whereDate()/whereTime()reparsedCarbon/DateTimeInterfacevalues using the app's default timezone instead of converting them, silently shifting the compared instant when the passed value was in a different timezone.config('app.timezone')before truncating to the date/time part.Test plan
whereDate/whereTimewith aCarboninstance in a non-app timezonewhereDate/whereMonth/whereDay/whereYear/whereTimetests still pass