Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes SDL's mouse cursors through a new
ICursorService, registered byBuild().CreateSystemCursor(SystemCursor),CreateCursor(Image, Vector2Int hotspot)andCreateCursor(ReadOnlySpan<CursorFrame>, Vector2Int hotspot)for animated cursors (SDL_CreateAnimatedCursor, SDL 3.4).SetCursor(Cursor),ResetCursor()andIsCursorVisible.PixelyFactoryshuts SDL down. All calls must be on the main thread.SystemCursorhas only the SDL 3.4 shapes, because browser archives are SDL 3.4.2.ImageSurfaces.GetPackedPitch, now also used bySdlImageWriterandWindow.SetIcon.SetIconpreviously assumed 4 bytes per pixel and could read past the image for other formats; it now throwsNotSupportedExceptionfor such images.Docs:
docs/cursors.md, plus notes indocs/headless.mdanddocs/hosting.md. Tutorial:Pixely.Tutorials.Cursor.Testing:
CursorServiceTestson SDL's dummy driver cover validation, lifetime, the main-thread rule and the SDL calls. The dummy driver has no system cursors, soCreateSystemCursoris tested only for its failure path there.