ci: pin third-party actions to full commit SHAs#3026
Open
kobihikri wants to merge 1 commit into
Open
Conversation
Pin third-party actions on mutable @master/@main tags in credentialed jobs: - chetan/invalidate-cloudfront-action (web.release.prod.yml) — handed production AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY - convictional/trigger-workflow-and-wait (snjs.pr.yml, e2e jobs) — handed CI_PAT_TOKEN - johnnyhuy/actions-discord-git-webhook (web.release.prod.yml) — handed DISCORD_WEBHOOK_URL A moved tag would run unreviewed code with those credentials. Behaviour unchanged; per GitHub's pin-to-SHA guidance. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin three third-party actions currently on
@master/@mainto their commit SHA:chetan/invalidate-cloudfront-action@masterweb.release.prod.yml(deploy)convictional/trigger-workflow-and-wait@mastersnjs.pr.yml(e2e-base, e2e-vaults)CI_PAT_TOKEN(PAT)johnnyhuy/actions-discord-git-webhook@mainweb.release.prod.yml(notify)DISCORD_WEBHOOK_URLWhy
@master/@mainare moving refs. Theinvalidate-cloudfront-actionstep is handed the production AWSaccess key + secret; a moved tag there (compromise or an accidental change) would run unreviewed code
with those keys — the class behind the 2025
tj-actions/changed-filesincident, here allowing S3/CloudFronttakeover. Pinning to a SHA removes that.
Scope / safety
Behaviour unchanged (each SHA is the current tip). Signed-off. Per GitHub's pin-to-SHA guidance.
AI-assisted; I verified the workflows, the credential exposure, and the pinned SHAs myself.