Skip to content

Support additional normal_id_glm_lpdf signatures - #1698

Merged
WardBrian merged 2 commits into
stan-dev:masterfrom
VisruthSK:normal-id-glm-sig-change
Sep 8, 2026
Merged

Support additional normal_id_glm_lpdf signatures#1698
WardBrian merged 2 commits into
stan-dev:masterfrom
VisruthSK:normal-id-glm-sig-change

Conversation

@VisruthSK

@VisruthSK VisruthSK commented Sep 7, 2026

Copy link
Copy Markdown
Member

This PR was assisted by ChatGPT.

Submission Checklist

Release notes

Support row-vector and vector inputs for x in normal_id_glm_lpdf.

Closes #1354.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@VisruthSK
VisruthSK marked this pull request as ready for review September 7, 2026 00:34
Comment thread src/stan_math_signatures/Generate.ml
@WardBrian

Copy link
Copy Markdown
Member

Also, thanks for doing this!

@VisruthSK

Copy link
Copy Markdown
Member Author

Of course, been meaning to learn/practice OCaml so I might be making a few more PRs as I see low hanging fruit. Does this merit a doc change btw?

@WardBrian

Copy link
Copy Markdown
Member

I think it would, but it will mostly be a copy/paste job to add more signatures to https://mc-stan.org/docs/functions-reference/unbounded_continuous_distributions.html#index-entry-4436deedaa4adcaf697328f4ab6228f12bf213be

@WardBrian WardBrian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WardBrian
WardBrian merged commit 8a920c1 into stan-dev:master Sep 8, 2026
3 checks passed
@VisruthSK
VisruthSK deleted the normal-id-glm-sig-change branch September 8, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose additional normal_id_glm pointwise signatures

2 participants