Rely more on posterior - #1171
Conversation
Rewrote some functions to act as wrappers around posterior functions, and swap in posterior functions in check_hmc_diagnostics.R
|
Oh and posterior also needs to be added to the DESCRIPTION file |
…t run the test locally [ci skip]
|
I added a snapshot based on an example model Jonah wrote for |
|
I think for testing monitor we should pass it a fixed set of posterior draws instead of creating a stanfit object (it can handle both). That's because with different hardware and different compilers results can be slightly different. So we'd have to set a tolerance but that could be fragile. I just pushed a commit that updates the test to do this. |
|
@bgoodri When reviewing this PR I noticed that the monitor function is a bit of a mess (not @VisruthSK's fault, this was the case before this PR). I don't understand why there's a |
|
Thanks for generating the snapshot. |
Uses more
posteriorfunctions inmonitor.Rfor various functions. Exported functions are replaced with minimal wrappers, others are removed.There are no tests for
monitor.R, but running some examples seems to be ok. I can add tests if required (probably just snapshots using those examples).Fixes #1169.
@jgabry @avehtari