Skip to content

Implement trace_dot#3310

Open
jachymb wants to merge 5 commits intostan-dev:developfrom
jachymb:jachymb_trace_dot
Open

Implement trace_dot#3310
jachymb wants to merge 5 commits intostan-dev:developfrom
jachymb:jachymb_trace_dot

Conversation

@jachymb
Copy link
Copy Markdown

@jachymb jachymb commented Apr 23, 2026

Summary

Implements the trace_dot function that computes Tr(A * B) efficiently. This can be used to simplify code on some places.

I requested this in #3161 and decided to try it myself.

Tests

Tests for the new functions, inspired by tests for related functions.

Side Effects

Should not have.

Release notes

Implement trace_dot(A, B).

Checklist

AI use disclosure*

I made this with help of claude code Opus 4.6

@jachymb
Copy link
Copy Markdown
Author

jachymb commented Apr 24, 2026

Not sure what does the "Upstream CmdStan tests" failure indicate. Can anyone help? Is it maybe just a transient issue and simply rerunning the tests would be enough?

@WardBrian
Copy link
Copy Markdown
Member

It looks like the tests tried to run during a GitHub outage, which caused the failure. I've triggered a re-run

@SteveBronder
Copy link
Copy Markdown
Collaborator

Thanks! I made a few little changes that were easier to show then tell. Once this passes the tests I'll merge!

SteveBronder
SteveBronder previously approved these changes Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants