Add 4.11.2 version - #441
Conversation
📝 WalkthroughWalkthroughAdds the RHACS operator ChangesRHACS operator release candidate
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@catalog-template.yaml`:
- Around line 3154-3156: Move the rhacs-operator.v4.11.2-rc.1 entry from the
stable channel block to the intended candidate channel, preserving its replaces
and skipRange values so stable subscribers cannot receive the prerelease
version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1a790e8c-e2de-43ba-b1bd-ac149760a158
📒 Files selected for processing (4)
bundles.yamlcatalog-bundle-object/rhacs-operator/catalog.jsoncatalog-csv-metadata/rhacs-operator/catalog.jsoncatalog-template.yaml
| - name: rhacs-operator.v4.11.2-rc.1 | ||
| replaces: rhacs-operator.v4.11.1 | ||
| skipRange: ">= 4.10.0 < 4.11.2-rc.1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the target region with line numbers
sed -n '3135,3175p' catalog-template.yaml | cat -n
# Search for nearby channel markers and this package/version
rg -n '^( - name:|channel:|name: rhacs-operator\.v4\.11\.2-rc\.1|replaces: rhacs-operator\.v4\.11\.1|skipRange:)' catalog-template.yamlRepository: stackrox/operator-index
Length of output: 40196
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the target block with exact line numbers
nl -ba catalog-template.yaml | sed -n '3145,3165p'
# Show the nearest enclosing channel header above the target line
awk 'NR<=3156 { if ($0 ~ /^ - name:/) last=$0; if ($0 ~ /^channel:/) chan=$0 } END { print "LAST_ENTRY=" last; print "LAST_CHANNEL=" chan }' catalog-template.yamlRepository: stackrox/operator-index
Length of output: 201
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Print the surrounding block with line numbers without relying on nl
awk 'NR>=3090 && NR<=3175 { printf "%6d %s\n", NR, $0 }' catalog-template.yaml
# Locate the nearest channel/schema headers above the target region
awk 'NR>=3000 && NR<=3175 && /^- schema: olm\.channel|^ name:|^ entries:|^ - name:|^ package:|^channel:/' catalog-template.yamlRepository: stackrox/operator-index
Length of output: 6082
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show a wider window to capture the channel header above the target entries
awk 'NR>=3030 && NR<=3160 { printf "%6d %s\n", NR, $0 }' catalog-template.yaml
# Find the nearest preceding channel name for the target line
python3 - <<'PY'
from pathlib import Path
lines = Path("catalog-template.yaml").read_text().splitlines()
target = 3154 # 1-based line number from the review comment
channel = None
schema = None
for i in range(target - 1, -1, -1):
line = lines[i]
if line.startswith(" name: "):
channel = line.strip()
break
if line.startswith("- schema: "):
schema = line.strip()
break
print("nearest_name_line:", channel)
print("nearest_schema_line:", schema)
PYRepository: stackrox/operator-index
Length of output: 5712
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the channel header and the start of the current block around the target version
awk 'NR>=2828 && NR<=2865 { printf "%6d %s\n", NR, $0 }' catalog-template.yaml
# Show any channel names in the same file that mention rc.1
rg -n '^ - name: rhacs-operator\.v4\.11\.2-rc\.1$|^ - name: stable$|^ - name: candidate$|^ - name: fast$' catalog-template.yamlRepository: stackrox/operator-index
Length of output: 1822
Keep the RC out of stable. rhacs-operator.v4.11.2-rc.1 is in the stable channel block, so stable subscribers can be offered prerelease code via replaces/skipRange. Move it to the intended candidate channel unless stable is meant to carry RCs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@catalog-template.yaml` around lines 3154 - 3156, Move the
rhacs-operator.v4.11.2-rc.1 entry from the stable channel block to the intended
candidate channel, preserving its replaces and skipRange values so stable
subscribers cannot receive the prerelease version.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@catalog-template.yaml`:
- Around line 3154-3156: Move the rhacs-operator.v4.11.2-rc.2
ClusterServiceVersion entry out of the stable channel and into the intended
candidate channel, preserving its replaces and skipRange values. Do not leave
the release candidate available to stable subscribers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0caf73ee-5a8a-4d64-8f5d-c56a4050bfd7
📒 Files selected for processing (4)
bundles.yamlcatalog-bundle-object/rhacs-operator/catalog.jsoncatalog-csv-metadata/rhacs-operator/catalog.jsoncatalog-template.yaml
| - name: rhacs-operator.v4.11.2-rc.2 | ||
| replaces: rhacs-operator.v4.11.1 | ||
| skipRange: ">= 4.10.0 < 4.11.2-rc.2" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major
Keep the release candidate out of stable.
rhacs-operator.v4.11.2-rc.2 is still published in the stable channel, so stable subscribers can be upgraded to prerelease code via replaces and skipRange. Move this entry to the intended candidate channel, or confirm and document that stable intentionally carries release candidates.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@catalog-template.yaml` around lines 3154 - 3156, Move the
rhacs-operator.v4.11.2-rc.2 ClusterServiceVersion entry out of the stable
channel and into the intended candidate channel, preserving its replaces and
skipRange values. Do not leave the release candidate available to stable
subscribers.
1 participant
WIP - currently 4.11.2-rc.2