Conversation
* fix(tests): wait for plop server instead of fixed sleep TestProcessListeningOnPort slept a fixed 5s after starting the flask "plop" container and then made a single request with no retry. Since the GCP ubuntu-2404-lts-amd64 image moved to a newer kernel (around 2026-09-05), flask's first start on that VM often takes longer than 5s, so the suite fails with "connection refused" on ubuntu-os in most runs. ubuntu-2204 binds in 3-5s and has lost the same race too. Flask isn't hung. In the failing runs the container had only been up for 5-6s when the request was made, and in one it had already printed "Serving Flask app". The next suite (TestSymbolicLinkProcess) starts the same image on the same VM and it binds port 5000 within 0-7s. Poll the port for up to 30s instead, so the test waits as long as it needs to and fails with a clear message if the server never comes up. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com> * fix: shorten plop readiness timeout to 15s Review feedback: 30s delays the error when the plop container fails to start. CI showed flask binding in up to ~8s on ubuntu-2404, so 15s keeps headroom for slower kernels without a long wait on real failures. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com> --------- Signed-off-by: Saif Chaudhry <schaudhr@redhat.com> (cherry picked from commit 1b6093d) Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-3.26 #4064 +/- ##
=============================================
Coverage 27.34% 27.34%
=============================================
Files 95 95
Lines 5420 5420
Branches 2545 2545
=============================================
Hits 1482 1482
Misses 3211 3211
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
/konflux-retest collector-on-push |
2 similar comments
|
/konflux-retest collector-on-push |
|
/konflux-retest collector-on-push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4045 to release-3.26.
TestProcessListeningOnPortis still failing on ubuntu-os on this branch withconnection refused. #4045 replaces the fixed 5s sleep with a poll on port 5000 (500ms interval, 15s timeout). Since it merged, ubuntu-os has passed 25 of 25 runs on master.Clean cherry-pick.
go build ./...andgo vet ./suites/pass inintegration-tests.Tracked in ROX-37266.