Skip to content

WIP: Check actual volume size after volume expand to verify if expand…#1044

Draft
nschad wants to merge 1 commit intomainfrom
sanity-check-expand
Draft

WIP: Check actual volume size after volume expand to verify if expand…#1044
nschad wants to merge 1 commit intomainfrom
sanity-check-expand

Conversation

@nschad
Copy link
Copy Markdown
Contributor

@nschad nschad commented Apr 29, 2026

… was successful

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Problem mitigation. This also happens on the openstack CSI.

The problem is that the expand is async and therefore later-on can be rejected (due to i.e. storage policies), while still pretending to been have successful. This check checks the actual volume size and then reports an error. Additionally it also retries.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

… was successful

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Apr 29, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 29, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant