ci: use diff of previous patchset for path filters#2373
Closed
Alex-Welsh wants to merge 1 commit into
Closed
Conversation
When a user makes a PR, CI is run conditionally based on the files that change. If a second commit is then pushed, e.g. to update docs or add a relase note, that commit would retrigger all CI even though it doesn't affect the filtered files. This change fixes that interaction, so the new patchset is compared to the previous, instead of the branch it is merging into.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Alex-Welsh
force-pushed
the
ci-smarter-reruns
branch
from
2e51434 to
1f0d0f6
Compare
Member
Author
|
Cool idea I think, but I've just realised it can be used to bypass CI if you push a major change, then quickly push a minor one - to docs or something - before CI on the first one is finished. Would have to check the status of the previous patchset and that seems like a bit of a mess. Dropping this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user makes a PR, CI is run conditionally based on the files that change. If a second commit is then pushed, e.g. to update docs or add a relase note, that commit would retrigger all CI even though it doesn't affect the filtered files. This change fixes that interaction, so the new patchset is compared to the previous, instead of the branch it is merging into.