Remove hostname from AIO alert matches#18
Draft
Alex-Welsh wants to merge 1 commit into
Draft
Conversation
In the past we would reboot AIOs and set a known hostname, so we could match on controller0. The reboot is no longer required, so AIOs get random names, so matching doesn't work.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Prometheus monitoring tests by removing the "instance": "controller0" constraint from several alerts in the aio_alerts_to_ignore list, making the ignore rules more generic. There are no review comments to address, and no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Member
Author
|
See also stackhpc/stackhpc-kayobe-config#2374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we would reboot AIOs and set a known hostname, so we could match on controller0. The reboot is no longer required, so AIOs get random names, so matching doesn't work.
Currently untested