Fix ironic instance rebuild with API >=2.93 - cherry-pick from 2025.1#212
Open
Alex-Welsh wants to merge 1 commit into
Open
Fix ironic instance rebuild with API >=2.93 - cherry-pick from 2025.1#212Alex-Welsh wants to merge 1 commit into
Alex-Welsh wants to merge 1 commit into
Conversation
When you attempt to rebuild an Ironic instance, using the CLI, it will pick the latest micversion, which triggers sending to the ironic driver: reimage_boot_volume = true The ironic driver then raises an exception, saying it is unable to rebuild a volume backed instance. This happens even when the instance is not volume backed, and rebuild would be fine. This patch ensures we only raise the "can't rebuild" exception when the instance is volume backed. Closes-Bug: #2127017 Change-Id: Ibb8e83a1d36506df34a324ca0da9e2f129a38cfa Signed-off-by: John Garbutt <john.garbutt@stackhpc.com> Assisted-By: Github Copilot Free (cherry picked from commit 2c8f0e0b3a9c42260e86b894c4e5344a16b187bc) (cherry picked from commit d81aad7)
Member
Author
|
DNM until we decide if we want to use zuul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you attempt to rebuild an Ironic instance, using the CLI, it will pick the latest micversion, which triggers sending to the ironic driver:
reimage_boot_volume = true
The ironic driver then raises an exception, saying it is unable to rebuild a volume backed instance. This happens even when the instance is not volume backed, and rebuild would be fine.
This patch ensures we only raise the "can't rebuild" exception when the instance is volume backed.
Closes-Bug: #2127017
Change-Id: Ibb8e83a1d36506df34a324ca0da9e2f129a38cfa
Assisted-By: Github Copilot Free
(cherry picked from commit 2c8f0e0b3a9c42260e86b894c4e5344a16b187bc) (cherry picked from commit d81aad7)