Skip to content

chore: Replace serde_yaml with yaml_serde - #802

Merged
xeniape merged 2 commits into
mainfrom
chore/replace-serde-yaml
Oct 14, 2026
Merged

xeniape merged 2 commits into
mainfrom
chore/replace-serde-yaml

Conversation

@xeniape

@xeniape xeniape commented Oct 14, 2026

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#898

Integrationtests

--- PASS: kuttl (1734.01s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_superset-6.1.0_ldap-authentication-server-verification-tls_openshift-false (198.38s)
        --- PASS: kuttl/harness/opa_superset-4.1.4_opa-latest-1.16.2_openshift-false (363.58s)
        --- PASS: kuttl/harness/ldap_superset-6.1.0_ldap-authentication-no-tls_openshift-false (100.96s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-6.1.0_openshift-false (307.72s)
        --- PASS: kuttl/harness/ldap_superset-6.1.0_ldap-authentication-insecure-tls_openshift-false (105.75s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-server-verification-tls_openshift-false (99.34s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-no-tls_openshift-false (101.32s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-insecure-tls_openshift-false (103.12s)
        --- PASS: kuttl/harness/external-access_superset-6.1.0_openshift-false (88.88s)
        --- PASS: kuttl/harness/logging_superset-6.1.0_openshift-false (117.83s)
        --- PASS: kuttl/harness/external-access_superset-4.1.4_openshift-false (78.85s)
        --- PASS: kuttl/harness/druid-connection_superset-4.1.4_openshift-false (70.07s)
        --- PASS: kuttl/harness/logging_superset-4.1.4_openshift-false (101.88s)
        --- PASS: kuttl/harness/smoke_superset-6.1.0_openshift-false (97.56s)
        --- PASS: kuttl/harness/oidc_superset-4.1.4_openshift-false (123.71s)
        --- PASS: kuttl/harness/resources_superset-latest-6.1.0_openshift-false (71.33s)
        --- PASS: kuttl/harness/smoke_superset-4.1.4_openshift-false (106.62s)
        --- PASS: kuttl/harness/oidc_superset-6.1.0_openshift-false (139.25s)
        --- PASS: kuttl/harness/celery-worker_superset-6.1.0_openshift-false (147.11s)
        --- PASS: kuttl/harness/upgrade_superset-old-4.1.4_superset-new-6.1.0_authentication-oidc_openshift-false (208.44s)
        --- PASS: kuttl/harness/upgrade_superset-old-4.1.4_superset-new-6.1.0_authentication-none_openshift-false (121.92s)
        --- PASS: kuttl/harness/druid-connection_superset-6.1.0_openshift-false (69.48s)
        --- PASS: kuttl/harness/opa_superset-6.1.0_opa-latest-1.16.2_openshift-false (293.18s)
        --- PASS: kuttl/harness/celery-worker_superset-4.1.4_openshift-false (129.96s)
PASS

Unittests

test result: ok. 49 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 14, 2026
@xeniape
xeniape marked this pull request as ready for review October 14, 2026 11:48
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 14, 2026

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

Comment thread rust/operator-binary/src/crd/authentication.rs
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 14, 2026
@xeniape
xeniape requested a review from sbernauer October 14, 2026 13:10
@xeniape
xeniape added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 5a7f9b9 Oct 14, 2026
13 checks passed
@xeniape
xeniape deleted the chore/replace-serde-yaml branch October 14, 2026 13:25
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants