Skip to content

fix: Add missing owns/watches and test early-exit reconcile - #781

Merged
adwk67 merged 3 commits into
mainfrom
fix/missing-owns-and-early-exit
Aug 26, 2026
Merged

fix: Add missing owns/watches and test early-exit reconcile#781
adwk67 merged 3 commits into
mainfrom
fix/missing-owns-and-early-exit

Conversation

@adwk67

@adwk67 adwk67 commented Aug 25, 2026

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#878

--- PASS: kuttl (650.34s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-6.1.0_openshift-false (650.33s)
PASS

This PR ensures that the operator now watches all resources that it creates and early-exits the reconcile action when the cluster is marked for deletion. This is tested at unit-test level, as well as by adding a step to one of the kuttl tests to delete all relevant objects and assert that they are re-created.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added in parent issue

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Aug 25, 2026
@adwk67
adwk67 marked this pull request as ready for review August 25, 2026 10:59
@adwk67
adwk67 requested a review from maltesander August 25, 2026 10:59

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the druid_controller get the early return as well?

@adwk67

adwk67 commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Should the druid_controller get the early return as well?

Added here 5e07795

@adwk67
adwk67 requested a review from maltesander August 26, 2026 09:49

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67
adwk67 added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit e042d16 Aug 26, 2026
13 checks passed
@adwk67
adwk67 deleted the fix/missing-owns-and-early-exit branch August 26, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants