Skip to content

chore!: Put clientAuthenticationMethod field behind opt-in#1194

Merged
sbernauer merged 6 commits intomainfrom
fix/make-client-authentication-method-opt-in
Apr 9, 2026
Merged

chore!: Put clientAuthenticationMethod field behind opt-in#1194
sbernauer merged 6 commits intomainfrom
fix/make-client-authentication-method-opt-in

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Popped up in stackabletech/trino-operator#877 (comment)

I also gave generics a bit more speaking names, but happy to revert that if you think they are too long.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer changed the title fix!: Put clientAuthenticationMethod field behind opt-in chore!: Put clientAuthenticationMethod field behind opt-in Apr 8, 2026
Comment thread crates/stackable-operator/src/crd/authentication/core/mod.rs Outdated
dervoeti
dervoeti previously approved these changes Apr 8, 2026
Copy link
Copy Markdown
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a nit comment but LGTM

@sbernauer sbernauer requested a review from dervoeti April 9, 2026 06:39
@sbernauer sbernauer moved this to Development: In Review in Stackable Engineering Apr 9, 2026
@sbernauer sbernauer self-assigned this Apr 9, 2026
dervoeti
dervoeti previously approved these changes Apr 9, 2026
@sbernauer sbernauer added this pull request to the merge queue Apr 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 9, 2026
@sbernauer sbernauer added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit e98154e Apr 9, 2026
5 checks passed
@sbernauer sbernauer deleted the fix/make-client-authentication-method-opt-in branch April 9, 2026 07:45
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 10, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants