Skip to content

ci: Add PR workflows, pre-commit, release updates, and build fixes - #35

Merged
Techassi merged 5 commits into
stackabletech:mainfrom
Saul-STFC:ci-cd-testing
Aug 20, 2026
Merged

ci: Add PR workflows, pre-commit, release updates, and build fixes#35
Techassi merged 5 commits into
stackabletech:mainfrom
Saul-STFC:ci-cd-testing

Conversation

@Saul-STFC

Copy link
Copy Markdown
Contributor

This PR introduces foundational CI/CD pipelines and code quality tooling for our Java repositories. Once merged, this standard setup can serve as a template to bereplicated across our other Java repos.

Changes:

• Added automated PR checks (pr_build.yaml, pr_prek.yaml) to build and validate code on every pull request.
• Pinned GitHub Action hashes and converted simpler steps to native GitHub commands where actions were unnecessary.
• Configured .pre-commit-config.yaml with rules for yamllint and markdownlint to enforce formatting (mirroring other repos)
• Applied the new linting rules across the existing codebase
• Added a maven wrapper (mvnw) and its associated wrapper files to guarantee a consistent Maven version across all development and CI environments.
• Removed unused dummy tests (AppTest.java) and redundant files.

@Techassi
Techassi self-requested a review August 4, 2026 20:47
@Techassi Techassi moved this to Development: In Review in Stackable Engineering Aug 4, 2026
@Saul-STFC

Copy link
Copy Markdown
Contributor Author

@Techassi @NickLarsenNZ

@NickLarsenNZ

Copy link
Copy Markdown
Member

Thanks.

Does this supersede #33?

@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Aug 5, 2026
@Techassi Techassi moved this from Development: Done to Development: In Review in Stackable Engineering Aug 5, 2026
@Saul-STFC

Copy link
Copy Markdown
Contributor Author

Thanks.

Does this supersede #33?

Yes it does :)

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good. I left a few small comments.

One thing I cannot comment on at all is the Maven wrapper stuff. CC'ing @lfrancke here.

Comment thread .github/workflows/release_build.yaml
Comment thread .github/workflows/pr_build.yaml Outdated
Comment thread .github/workflows/pr_build.yaml Outdated
Comment thread authorizer/src/main/java/org/nifiopa/nifiopa/OpaAuthorizer.java
Comment thread docs/readme/component-logic.svg
Comment thread test-env/start.sh
Comment thread .github/workflows/release_build.yaml

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go from my side. @lfrancke still wanted to look at the Maven wrapper changes.

As such, I'm not approving as of yet.

@Saul-STFC

Copy link
Copy Markdown
Contributor Author

This is good to go from my side. @lfrancke still wanted to look at the Maven wrapper changes.

As such, I'm not approving as of yet.

That's fine. For context, it was just running mvn wrapper:wrapper so that builds are reproducible.

@lfrancke

Copy link
Copy Markdown
Member

Sorry, I had a quick look and it looks good to me.

One thing: The README still mentions running plain mvn - that should probably be updated as well then?

@Saul-STFC

Copy link
Copy Markdown
Contributor Author

Sorry, I had a quick look and it looks good to me.

One thing: The README still mentions running plain mvn - that should probably be updated as well then?

Done (#f2783755) , also while testing I noticed the readme has the wrong demo users, it had user1, user2 etc instead of user01, user02 in the test-env so I have updated that

@Techassi Techassi changed the title ci: add PR workflows, pre-commit, release updates, and build fixes ci: Add PR workflows, pre-commit, release updates, and build fixes Aug 20, 2026
@Techassi
Techassi merged commit 3c8b0af into stackabletech:main Aug 20, 2026
6 checks passed
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Aug 20, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants