fix: Lifecycle Policies menu entry not correct (now in header menu) - #931
Merged
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
xeniape
approved these changes
Sep 3, 2026
xeniape
left a comment
xeniape
left a comment
Member
There was a problem hiding this comment.
Ah! Yes, the earlier PR "fixed" it in the navigation bar to the left, where it was already correct, because if there is nothing specified in [] it takes the title of the page I think, which was already "Lifecycle Policies". So we could remove it again if the title ever changes so it's reflected in the navigation bar (which I guess is unlikely so it does not hurt either)
StefanFl
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what the file edited in #928 is for, but the header menu will get the proper title for Lifecycle Policies with this PR.