Skip to content

test: Fix the restarter test#416

Merged
siegfriedweber merged 5 commits intomainfrom
fix/restarter-test
Apr 22, 2026
Merged

test: Fix the restarter test#416
siegfriedweber merged 5 commits intomainfrom
fix/restarter-test

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber commented Apr 22, 2026

Description

Fix the restarter test:

  • Use test-script.sh within the KUTTL _work directory instead of the templates directory.
  • Fix the restarter labels and annotations; They were not effective in this test case.
  • Wait for some time in the hot reloading step to ensure that the configuration changes happened due to hot-reloading and not due to a pod restart; Without this wait period, the test step succeeded most of the times. Now, it reliably fails, if e.g. labels and annotations are swapped as before.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber requested a review from a team April 22, 2026 11:30
@siegfriedweber siegfriedweber self-assigned this Apr 22, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Apr 22, 2026
@siegfriedweber siegfriedweber marked this pull request as draft April 22, 2026 11:41
@siegfriedweber siegfriedweber marked this pull request as ready for review April 22, 2026 13:15
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Apr 22, 2026
@adwk67 adwk67 requested review from adwk67 and removed request for a team April 22, 2026 13:25
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 22, 2026
adwk67
adwk67 previously approved these changes Apr 22, 2026
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have suggested a comment as I tripped up over the issues with the kuttl version.

Comment thread tests/templates/kuttl/restarter/10-assert.yaml
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
@siegfriedweber siegfriedweber added this pull request to the merge queue Apr 22, 2026
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Apr 22, 2026
Merged via the queue into main with commit 41f4203 Apr 22, 2026
10 checks passed
@siegfriedweber siegfriedweber deleted the fix/restarter-test branch April 22, 2026 14:38
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants