Repository navigation
tclsh/wish: mk install builds the test interpreters; harnesses say wh… - #603
Merged
Merged
Conversation
…ich they are
`mk distclean' removed cmd/tclsh/tcltest -- it is in that mkfile's
CLEANFILES -- and `mk install' did not rebuild it, because it was a
V: target reachable from nothing. The next whole-suite run therefore
used plain tclsh, where `package require tcl::test' fails:
before: Total 68118 Passed 62138 Skipped 5916 Failed 64
after: Total 66970 Passed 55700 Skipped 11233 Failed 37
mutex.test requires the package at the top level and brodnik.test's
`try {package require tcl::test}' has no handler clause, so both
abort on that line -- which is the `Test files exiting with errors'
entry that named the cause. Everything constrained on a testing
command skipped, and the failure count FELL by 27.
tcltest is a file target with `install:V: tcltest' beside it now;
every V: rule for a target runs in Plan 9 mk, so it is built beside
tclsh without being installed into $BIN. cmd/wish/tktest had the
same asymmetry -- its clean:V: removes it -- and gets the same fix.
tcl-runall.tcl REFUSES to run without tcl::test, naming the two
commands that fix it, with $APEXP_TCL_ANYSHELL=1 as the escape for
asking what the installed tclsh does. tk-runall.tcl warns instead,
since no Tk file aborts and only comparability is lost; its marker
is testbitmap, which tkTest.c:222 registers unconditionally where
testmetrics and testmenubar are behind platform ifdefs.
Also recorded in CLAUDE.md: structalign-test's three runs (14
failures under `pcc -9', 0 under `pcc', section 8 passing in both),
and cfront no longer faulting at pc=0x280db8 -- it exits 5 with real
C++ diagnostics and its output grew 1265 -> 5747 bytes, which is the
`name' 144 -> 152 prediction confirmed behaviourally. `pcc -9' is
the one command that would separate -J from the sualign fix there.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ich they are
mk distclean' removed cmd/tclsh/tcltest -- it is in that mkfile's CLEANFILES -- andmk install' did not rebuild it, because it was a V: target reachable from nothing. The next whole-suite run therefore used plain tclsh, where `package require tcl::test' fails:before: Total 68118 Passed 62138 Skipped 5916 Failed 64
after: Total 66970 Passed 55700 Skipped 11233 Failed 37
mutex.test requires the package at the top level and brodnik.test's
try {package require tcl::test}' has no handler clause, so both abort on that line -- which is theTest files exiting with errors' entry that named the cause. Everything constrained on a testing command skipped, and the failure count FELL by 27.tcltest is a file target with `install:V: tcltest' beside it now; every V: rule for a target runs in Plan 9 mk, so it is built beside tclsh without being installed into $BIN. cmd/wish/tktest had the same asymmetry -- its clean:V: removes it -- and gets the same fix.
tcl-runall.tcl REFUSES to run without tcl::test, naming the two commands that fix it, with $APEXP_TCL_ANYSHELL=1 as the escape for asking what the installed tclsh does. tk-runall.tcl warns instead, since no Tk file aborts and only comparability is lost; its marker is testbitmap, which tkTest.c:222 registers unconditionally where testmetrics and testmenubar are behind platform ifdefs.
Also recorded in CLAUDE.md: structalign-test's three runs (14 failures under
pcc -9', 0 underpcc', section 8 passing in both), and cfront no longer faulting at pc=0x280db8 -- it exits 5 with real C++ diagnostics and its output grew 1265 -> 5747 bytes, which is thename' 144 -> 152 prediction confirmed behaviourally.pcc -9' is the one command that would separate -J from the sualign fix there.Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs