Repository navigation
cmd/mkfile: comments broke the _OPTIONAL_APPS continuation - #600
Merged
Merged
Conversation
mk: mkfile:96: syntax error; expected one of :<= cmd/mkfile's own header says every comment line inside these lists has to end in a backslash, because the list is one continued line and a comment without one ends the assignment there. The block added this round to explain why c++lib and basic are off has four such lines, so _OPTIONAL_APPS ended at cfront and everything from adeb to curl became a fresh logical line starting with a bare word. The reported line is where the runaway logical line ends, not where it starts: line 96 is an ordinary DIRS= and the fault is 26 lines earlier. It is not bash's mkfile, which was the first suspect; every construct in that file's new comment has a working precedent elsewhere in the tree. mkcont-sweep.py sweeps the class and gates on it, unlike ishadow-sweep: every hit is a real break. Its discriminator is that a comment ending a continuation is usually deliberate -- lib/png/mkfile:42 is a commented-out OFILES tail -- so it reports only those where the next logical line is a bare word. Ten packages re-enter _OPTIONAL_APPS with this: adeb, dwarfdump, hell, pcregrep, diff, patch, mkmk, samurai, openssl, curl. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mk: mkfile:96: syntax error; expected one of :<=
cmd/mkfile's own header says every comment line inside these lists has to end in a backslash, because the list is one continued line and a comment without one ends the assignment there. The block added this round to explain why c++lib and basic are off has four such lines, so _OPTIONAL_APPS ended at cfront and everything from adeb to curl became a fresh logical line starting with a bare word.
The reported line is where the runaway logical line ends, not where it starts: line 96 is an ordinary DIRS= and the fault is 26 lines earlier. It is not bash's mkfile, which was the first suspect; every construct in that file's new comment has a working precedent elsewhere in the tree.
mkcont-sweep.py sweeps the class and gates on it, unlike ishadow-sweep: every hit is a real break. Its discriminator is that a comment ending a continuation is usually deliberate -- lib/png/mkfile:42 is a commented-out OFILES tail -- so it reports only those where the next logical line is a bare word.
Ten packages re-enter _OPTIONAL_APPS with this: adeb, dwarfdump, hell, pcregrep, diff, patch, mkmk, samurai, openssl, curl.
Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs