Repository navigation
kencc: pcc was passing -J itself, and names -a now - #597
Merged
Merged
Conversation
pcc.c's if(!Aflag) block appended -J to the compiler on every invocation, commented "old/new decl mixture hack". In stock cc -J is not a named flag: it reached ARGBEGIN's default, set debug['J'], and nothing in the tree reads debug['J'] -- a no-op for its entire life. Giving the letter a meaning therefore turned conforming struct layout on by default for every APE compile that passed neither -A nor -B, which is the silent ABI split the flag exists to avoid. It accounts for both loose ends of the previous round. structalign-test was run without -A or -B, so the command recorded as the control was the same compile as the one with -J, and its twelve predicted failures could not fire. cfrontsz-probe carries cfront's own -B, so no -J was appended and it measured the old rule in the same minute. Also forward -a and -Z to the compiler. pcc named neither, so "pcc -a apeabi-probe.c" answered "cc: flag -a ignored" and compiled normally, and the acid dump the probe exists for could not be taken. -c is required alongside them: with -a the compiler writes acid to stdout and produces no object. Twelve mkfiles spelled CC as an absolute path into $APEXPROOT where 48 others say plain pcc; normalised. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcc.c's if(!Aflag) block appended -J to the compiler on every invocation, commented "old/new decl mixture hack". In stock cc -J is not a named flag: it reached ARGBEGIN's default, set debug['J'], and nothing in the tree reads debug['J'] -- a no-op for its entire life. Giving the letter a meaning therefore turned conforming struct layout on by default for every APE compile that passed neither -A nor -B, which is the silent ABI split the flag exists to avoid.
It accounts for both loose ends of the previous round. structalign-test was run without -A or -B, so the command recorded as the control was the same compile as the one with -J, and its twelve predicted failures could not fire. cfrontsz-probe carries cfront's own -B, so no -J was appended and it measured the old rule in the same minute.
Also forward -a and -Z to the compiler. pcc named neither, so "pcc -a apeabi-probe.c" answered "cc: flag -a ignored" and compiled normally, and the acid dump the probe exists for could not be taken. -c is required alongside them: with -a the compiler writes acid to stdout and produces no object.
Twelve mkfiles spelled CC as an absolute path into $APEXPROOT where 48 others say plain pcc; normalised.
Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs