#394: added WebSocket.SendTimout to fix issue: https://github.com/sta…#395
Open
6opuc wants to merge 1 commit intosta:masterfrom
Open
#394: added WebSocket.SendTimout to fix issue: https://github.com/sta…#3956opuc wants to merge 1 commit intosta:masterfrom
6opuc wants to merge 1 commit intosta:masterfrom
Conversation
|
@sta Can we implement something like this? I'm running into an issue where my Socket.Send is just getting hung and not returning. This is causing my application to just sit there and not continue on. I am 100% sure that the state of the connection is open. Having the ability to put a timeout directly onto the send is the only way I can see our problem getting fixed. |
|
@sta Hi! I'm wondering if this has been solved because I'm facing similar issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/websocket-sharp/issues/394
Problem description:
One of our web socket clients for some reason stopped receiving messages(Some bug in our client code). This stopped message delivery to all other clients. After investigating this issue we saw that WebSocketServiceManager.Broadcast() got stuck on delivery to that buggy client for 5+ hours.
Steps to reproduce:
Actual result:
WebSocketServiceManager.Broadcast() got stuck on 172th iteration
Expected result:
Loop should complete successfully
Proposed solution:
Add property WebSocket.SendTimeout to limit sending message into socket.